Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate #79229

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Oct 1, 2020

Summary

Fixes: #79179

Don't stop user from creating a job if the mml is lower than the estimated mml - show warning but allow user to continue.

image

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Just left 1 suggestion.

@alvarezmelissa87 alvarezmelissa87 requested review from qn895 and removed request for walterra October 5, 2020 17:37
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-creation-mml branch from d754e4a to 2c7099a Compare October 5, 2020 20:17
@qn895
Copy link
Member

qn895 commented Oct 5, 2020

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 10.6MB 10.6MB +719.0B

History

  • 💚 Build #79257 succeeded d754e4a260f14aa9bb6a1a2039ee4525c3cf80b6
  • 💔 Build #78979 failed 8b29e8baa8ad6b687cd6e67bffd9039ca0a24ada

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 9b0dcaa into elastic:master Oct 6, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Oct 6, 2020
…model memory lower than estimate (elastic#79229)

* allow user to create job when mml is lower than estimate

* ensure mml validation works as expected
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-creation-mml branch October 6, 2020 14:08
alvarezmelissa87 added a commit that referenced this pull request Oct 6, 2020
…model memory lower than estimate (#79229) (#79670)

* allow user to create job when mml is lower than estimate

* ensure mml validation works as expected
gmmorris added a commit that referenced this pull request Oct 8, 2020
…into feature/task_manager_429

* 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits)
  Add license check to direct package upload handler. (#79653)
  [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193)
  [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594)
  Fine-tunes ML related text on Metrics UI (#79425)
  [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229)
  Add new "Add Data" tutorials (#77237)
  Update APM telemetry docs (#79583)
  Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611)
  Kibana request headers (#79218)
  ensure missing indexPattern error is bubbled up to error callout (#79378)
  Missing space fix (#79585)
  remove duplicate tab states (#79501)
  [data.ui] Lazy load UI components in data plugin. (#78889)
  Add generic type params to search dependency. (#79608)
  [Ingest Manager] Internal action for policy reassign (#78493)
  [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175)
  [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579)
  [ML] Hide Data Grid column options when histogram charts are enabled. (#79459)
  [Telemetry] Synchronous `setup` and `start` methods (#79457)
  [Observability] Persist time range across apps (#79258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] DF Analytics creation wizard: allow user to set model memory lower than estimate
5 participants